Color: add overload to accept hex string#4170
Merged
swharden merged 8 commits intoScottPlot:mainfrom Aug 26, 2024
Merged
Conversation
Contributor
|
@aespitia IMHO, this is not the best way to create this constructor. Create a first instance of the class to copy it to create the class itself is not very clean for me. Perhaps you could made a small change to this PR:
my 2 cts. |
Contributor
Author
i like it, can make updates |
Contributor
Author
|
@KroMignon updated PR with your suggestions, lmk if you had other thoughts. |
kebox7
reviewed
Aug 22, 2024
Member
|
This looks great! Thanks @aespitia @KroMignon and @kebox7 - I look forward to using this myself after the next release! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update to add an new Color overload described in this ticket
#4165
sample usage:
var clr = new ScottPlot.Color("#FF0000");