SignalXY: Improvements to rending and handling of rotated plots#4112
Merged
swharden merged 5 commits intoScottPlot:mainfrom Jul 30, 2024
Merged
SignalXY: Improvements to rending and handling of rotated plots#4112swharden merged 5 commits intoScottPlot:mainfrom
swharden merged 5 commits intoScottPlot:mainfrom
Conversation
…ble array version of SignalXY.
Also corrected some indexing issues (equivalent to fixes made to double array version).
Member
|
Thanks @BrianAtZetica, this looks great! I'll merge this in now and issue a new release tonight 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves some minor and some major rendering artefacts that were occurrign in Rotated SignalXY plots.
This incorporates changes made in a prevfious PR (#4102 ) that also attempted to refactor the plottable type to remove confusion between X and Y data types and X and Y axis directions.
The main artefact was best illustrated when plotting a rotated signal on inverted axes
After this PR the same code produces a smooth sinusoid:
The other artefacts demonstrated in #4102 are also resolved.
The PR also: