Skip to content

Axis line and span: Add EnableAutoscale property#4069

Merged
swharden merged 4 commits intoScottPlot:mainfrom
KroMignon:fix_4067
Jul 24, 2024
Merged

Axis line and span: Add EnableAutoscale property#4069
swharden merged 4 commits intoScottPlot:mainfrom
KroMignon:fix_4067

Conversation

@KroMignon
Copy link
Contributor

@KroMignon KroMignon commented Jul 15, 2024

Port IgnoreAxisAuto feature from ScottPlot 4.1 to 5.0

Add support for Crosshair, HorizontalLine, VerticalLine, HorizonzalSpan and VerticalSpan.

Port Recipe.

This should fix issue #4067.

Backport `IgnoreAxisAuto`feature from ScottPlot 4.1

Add support for `Crosshair`, `HorizontalLine`, `VerticalLine`, `HorizonzalSpan` and `VerticalSpan`.

Backport Recipe.
@KroMignon KroMignon changed the title Backport IgnoreAxisAuto from ScottPlot 4.1 Port IgnoreAxisAuto from ScottPlot 4.1 Jul 15, 2024
@KroMignon KroMignon changed the title Port IgnoreAxisAuto from ScottPlot 4.1 SP5: Port IgnoreAxisAuto from ScottPlot 4.1 Jul 15, 2024
@swharden
Copy link
Member

swharden commented Jul 24, 2024

Hi @KroMignon, thanks for this PR! I'm going to rename this property but otherwise leave it as it is. While doing this I had a couple thoughts for alternative implementations, so I'll list them here in case there's interest in shifting toward one of these later...

  1. It may be useful to take GetAxisLimits() out of IPlottable and create IHasAxisLimits which would contain it but also a flag like EnableAutoscale

  2. Alternatively we could put a List<IPlottale> somewhere named something like PlottablesExcludedFromAxisLimits

@swharden swharden changed the title SP5: Port IgnoreAxisAuto from ScottPlot 4.1 Axis line and span: Add EnableAutoscale property Jul 24, 2024
@swharden swharden enabled auto-merge (squash) July 24, 2024 01:21
@swharden swharden linked an issue Jul 24, 2024 that may be closed by this pull request
@swharden swharden merged commit 2a18e7d into ScottPlot:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore Axis line for AutoScale

2 participants