Fix interaction of axis panels when scale factor is more than 1#3994
Merged
swharden merged 3 commits intoScottPlot:mainfrom Jun 25, 2024
Merged
Fix interaction of axis panels when scale factor is more than 1#3994swharden merged 3 commits intoScottPlot:mainfrom
swharden merged 3 commits intoScottPlot:mainfrom
Conversation
Member
|
Thanks @bforlgreen, this looks great! I'll merge it in a few minutes 🚀 |
KroMignon
added a commit
to KroMignon/ScottPlot
that referenced
this pull request
Jun 26, 2024
* upstream/main: Fix interaction of axis panels when scale factor is more than 1 (ScottPlot#3994) Added ResetMinAndMaxValues() to DataLoggerSource.cs (ScottPlot#3993) CoordinateLine: add constructor overloads (ScottPlot#3987) Colormap.GetColors() (ScottPlot#3983) Added a constructor overload that accepts List<Coordinates> (ScottPlot#3982) Signal: improve support for IReadOnlyList<T> (ScottPlot#3978) Axes: improve sharpness of axis lines, tick marks, and grid lines (ScottPlot#3976) adding console write file name function (ScottPlot#3965) Color.ToColor() Sandbox: extend minimal API Sandbox: Create .NET API project SVG XML Updates (ScottPlot#3957) Repeat render if changes are made in invoked events (ScottPlot#3952) CI: autoformat Experimental DataLogger2 using a `CircularBuffer<T>` (ScottPlot#3946)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you set the ScaleFactor to a value greater than 1, then interaction with the Axis Panels (mouse interactions) was incorrect.
To repro the issue (without these changes), set the scale factor to something like 1.5 and then try to perform a marquee select in the YAxis only in the area pointed to by the arrow. You'll notice it doesn't work.
These changes scale the mouse pos like we do with all the other functions.
I have also cleaned up some of the Scale factor code