Skip to content

Signal: improve support for IReadOnlyList<T>#3978

Merged
swharden merged 5 commits intoScottPlot:mainfrom
sdpenner:IReadOnly-signal
Jun 25, 2024
Merged

Signal: improve support for IReadOnlyList<T>#3978
swharden merged 5 commits intoScottPlot:mainfrom
sdpenner:IReadOnly-signal

Conversation

@sdpenner
Copy link
Contributor

Added IReadOnlyList adder for creating a new signal. Just creates a generic list from the read only one.

Not sure this makes sense, as users could easily do the ToList() themselves...

closes #3942

   public Signal Signal<T>(IReadOnlyList<T> ys, double period = 1, Color? color = null)
   {
       SignalSourceGenericList<T> source = new(ys.ToList(), period);
       return Signal(source, color);
   }

@swharden
Copy link
Member

Thanks @sdpenner! I refined this PR to achieve an implementation that avoids the copying associated with ToArray()

@swharden swharden changed the title Added IReadOnlyList adder for creating a new signal Signal: improve support for IReadOnlyList<T> Jun 25, 2024
@swharden swharden merged commit 0624067 into ScottPlot:main Jun 25, 2024
@sdpenner sdpenner deleted the IReadOnly-signal branch June 25, 2024 18:16
KroMignon added a commit to KroMignon/ScottPlot that referenced this pull request Jun 26, 2024
* upstream/main:
  Fix interaction of axis panels when scale factor is more than 1 (ScottPlot#3994)
  Added ResetMinAndMaxValues() to DataLoggerSource.cs (ScottPlot#3993)
  CoordinateLine: add constructor overloads (ScottPlot#3987)
  Colormap.GetColors() (ScottPlot#3983)
  Added a constructor overload that accepts List<Coordinates> (ScottPlot#3982)
  Signal: improve support for IReadOnlyList<T> (ScottPlot#3978)
  Axes: improve sharpness of axis lines, tick marks, and grid lines (ScottPlot#3976)
  adding console write file name function (ScottPlot#3965)
  Color.ToColor()
  Sandbox: extend minimal API
  Sandbox: Create .NET API project
  SVG XML Updates (ScottPlot#3957)
  Repeat render if changes are made in invoked events (ScottPlot#3952)
  CI: autoformat
  Experimental DataLogger2 using a `CircularBuffer<T>` (ScottPlot#3946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal: Add support for IReadOnlyList<T>

2 participants