Ability to use custom-drawn markers by henkburgstra · Pull Request #386 · ScottPlot/ScottPlot

henkburgstra · 2020-05-12T19:18:56Z

New contributors should review CONTRIBUTING.md:
https://github.com/swharden/ScottPlot/blob/master/CONTRIBUTING.md

Purpose:
This is a non-evasive change. The existing interface remains unchanged.

I needed the ability to use custom-drawn markers. This change adds this ability. The change adds public field Settings.markerDrawer of type IMarkerDrawer. PlottableScatter.Render uses this field if present to draw markers.

New functionality (code):
Provide a code example demonstrating new functionality achieved with this pull request (if applicable)

Implementation of IMarkerDrawer (open triangle in this case) to be used in an Audiogram (https://en.wikipedia.org/wiki/Audiogram)

    public class LuchtGemaskeerdRechts : IMarkerDrawer
    {
        public void DrawMarker(Graphics gfx, PointF pixelLocation, MarkerShape shape, float size, Color color)
        {
            var c = new MarkerConfig(gfx, pixelLocation, shape, size, color);
            gfx.DrawPolygon(c.Pen, new PointF[] { 
                new PointF(pixelLocation.X, pixelLocation.Y - size / 2),
                new PointF(pixelLocation.X - size / 2, pixelLocation.Y + size / 2),
                new PointF(pixelLocation.X + size / 2, pixelLocation.Y + size / 2)
            });
        }
    }

To be used like this:

            plt.MarkerDrawer(new LuchtGemaskeerdRechts());

New functionality (image):

If this pull request changes how a plot is rendered, provide an image or screenshot demonstrating the new functionality:

Update van het origineel

This reverts commit dec07cc.

swharden · 2020-05-16T17:44:57Z

Hi @henkburgstra, thank you for this insightful suggestion! I really like how this PR uses interfaces to let the user create a custom marker. This seems like a really useful feature that could benefit many plottable objects.

However, this PR only addresses scatter plots. Rather than merge this PR, I added this topic to the ScottPlot roadmap because I think the whole library would benefit from refactoring away from the enum-based marker system to a class-based system with interfaces like the one you implemented here.

This is a really good idea, and it pains mt to close this PR, but I'd really like to implement this idea on a much wider scale. I'll ping you when I do so you can take a look and let me know what you think!

henkburgstra · 2020-05-17T10:45:29Z

Hi Scott, thank you very much for your thoughtful response!

Could I maybe help you with this? Thank you for keeping me updated, I would rather use the original ScottPlot library than my fork in our project :)

swharden · 2020-05-17T14:49:48Z

Could I maybe help you with this? Thank you for keeping me updated, I would rather use the original ScottPlot library than my fork in our project :)

Since the current marker system is enum based, markers are hard-coded into the library. The fastest way could be for me to add your custom markers to the enum-based system so you can use them immediately, then I work toward supporting custom markers in a future release.

To add a custom marker you could just add its name to the list of current markers.

https://github.com/swharden/ScottPlot/blob/ef59756715ac87c6d778fe783c81357a593561b2/src/ScottPlot/Markers.cs#L10-L27

Then add a case for that marker in the DrawMarker function (using the arguments that are passed in for location, size, and color)

https://github.com/swharden/ScottPlot/blob/ef59756715ac87c6d778fe783c81357a593561b2/src/ScottPlot/Markers.cs#L44-L46

You could either paste that code in this issue, or change the code and make a PR, and I can incorporate it into the main library pretty quick.

henkburgstra · 2020-06-09T07:16:29Z

Hi Scott, Many thanks for taking the time to respond. I apologize for my late reply. I think I will do as you suggested for now. Hopefully I can make a pull request later today or tomorrow. Thanks again, Henk.

…

On Sun, May 17, 2020 at 4:50 PM Scott W Harden ***@***.***> wrote: Could I maybe help you with this? Thank you for keeping me updated, I would rather use the original ScottPlot library than my fork in our project :) Since the current marker system is enum based, markers are hard-coded into the library. The fastest way could be for me to add your custom markers to the enum-based system so you can use them immediately, then I work toward supporting custom markers in a future release. To add a custom marker you could just add its name to the list of current markers. https://github.com/swharden/ScottPlot/blob/ef59756715ac87c6d778fe783c81357a593561b2/src/ScottPlot/Markers.cs#L10-L27 Then add a case for that marker in the DrawMarker function (using the arguments that are passed in for location, size, and color) https://github.com/swharden/ScottPlot/blob/ef59756715ac87c6d778fe783c81357a593561b2/src/ScottPlot/Markers.cs#L44-L46 You could either paste that code in this issue, or change the code and make a PR, and I can incorporate it into the main library pretty quick. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#386 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALOLDR7PEIOWDEUMJV3EH3RR72RRANCNFSM4M7DGUKA> .

henkburgstra and others added 7 commits May 12, 2020 20:17

Added interface IMarkerDrawer

83bd5ac

Added public field markerDrawer to Settings

dea349a

Added method MarkerDrawer to set settings.markerDrawer

7722be7

Use settings.markerDrawer to draw markers if present

bfb8d17

Merge pull request #1 from swharden/master

3214e50

Update van het origineel

add marker refactor to roadmap ScottPlot#386

dec07cc

Revert "add marker refactor to roadmap ScottPlot#386"

9cb591b

This reverts commit dec07cc.

swharden added a commit that referenced this pull request May 16, 2020

add marker refactor to roadmap #386

d58afd3

swharden closed this May 16, 2020

swharden mentioned this pull request Aug 14, 2020

Triaged Tasks and Features (May 2020) #412

Closed

53 tasks

swharden mentioned this pull request Dec 10, 2020

Triaged Tasks and Features (Dec 2020) #651

Closed

20 tasks

swharden mentioned this pull request Jan 26, 2021

Triaged Tasks and Features (Feb 2021) #716

Closed

48 tasks

swharden mentioned this pull request May 1, 2021

Bubble Plot #984

Merged

swharden mentioned this pull request May 17, 2021

Triaged Tasks and Features #1028

Closed

82 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to use custom-drawn markers#386

Ability to use custom-drawn markers#386
henkburgstra wants to merge 7 commits intoScottPlot:masterfrom
henkburgstra:master

henkburgstra commented May 12, 2020

Uh oh!

swharden commented May 16, 2020

Uh oh!

henkburgstra commented May 17, 2020

Uh oh!

swharden commented May 17, 2020

Uh oh!

henkburgstra commented Jun 9, 2020 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

henkburgstra commented May 12, 2020

Uh oh!

swharden commented May 16, 2020

Uh oh!

henkburgstra commented May 17, 2020

Uh oh!

swharden commented May 17, 2020

Uh oh!

henkburgstra commented Jun 9, 2020 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants