FillY bug fixes: Update poly coordinates instead of creating a new po…#3726
Merged
swharden merged 8 commits intoScottPlot:mainfrom Apr 25, 2024
Merged
FillY bug fixes: Update poly coordinates instead of creating a new po…#3726swharden merged 8 commits intoScottPlot:mainfrom
swharden merged 8 commits intoScottPlot:mainfrom
Conversation
…lygon to prevent loss of all set properties (marker, line and fill styles) when setting (updating) data source. Redirect LineStyle property to Poly to actually apply it.
Member
|
Thanks for the fix @SebastianDirks! I improved a few additional edge cases, and these fixes will be in the next release 👍 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lygon to prevent loss of all set properties (marker, line and fill styles) when setting (updating) data source. Redirect LineStyle property to Poly to actually apply it.
Use this space to describe what this pull request accomplishes.
FillY bug fixes: Update poly coordinates instead of creating a new polygon to prevent loss of all set properties (marker, line and fill styles) when setting (updating) data source. Redirect LineStyle property to Poly to actually apply it.
Refer to open issues by their number to help link them with this pull request.
should fix #3720 and #3723