Skip to content

Fix missing variable update in demo "Show value under mouse, multiple series"#3684

Merged
swharden merged 1 commit intoScottPlot:mainfrom
bluemodel:demo-fix
Apr 17, 2024
Merged

Fix missing variable update in demo "Show value under mouse, multiple series"#3684
swharden merged 1 commit intoScottPlot:mainfrom
bluemodel:demo-fix

Conversation

@jamaa
Copy link
Contributor

@jamaa jamaa commented Apr 17, 2024

one-line fix in demo code, see #3680

@jamaa
Copy link
Contributor Author

jamaa commented Apr 17, 2024

by the way, @swharden , in my last pull request you told me about allowing upstream maintainers to edit pull request branches https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I just realized that this option is only available for forks belonging to personal accounts, but my ScottPlot fork currently belongs to an organization and therefore that option is not there. So I am sorry for not activating it yet again, but for the future, I will move the fork to my personal account and activate it in the next PR!

@swharden
Copy link
Member

swharden commented Apr 17, 2024

So I am sorry for not activating it yet again, but for the future, I will move the fork to my personal account and activate it in the next PR!

Sounds like a plan! The main reason I recommend it (even for small PRs like this) is so I can edit changelog.md to credit your effort connect the dots between you, the issue, and the PR 👍

swharden added a commit that referenced this pull request Apr 17, 2024
@swharden swharden enabled auto-merge April 17, 2024 22:34
@swharden swharden disabled auto-merge April 17, 2024 22:35
@swharden swharden merged commit d612ce2 into ScottPlot:main Apr 17, 2024
@jamaa jamaa deleted the demo-fix branch April 18, 2024 18:15
@swharden swharden linked an issue Apr 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Demo: "Show Value Under Mouse, Multiple Series" is broken

2 participants