Conversation
Member
Author
|
Oof... can't do multiple inheritance in C# 💀 I can use interfaces, but that's a pain because the plottable developer will have to implement tons of little helper methods. I may have to rethink this strategy. So close! Default interface implementation methods were added in C# 8, but I can't use them since the app targets .NET Framework 😩
|
work needs to be done in #3669 for the same properties to apply to all plottables
swharden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks creation of abstract "style properties" classes which can be inherited by plottable classes which have objects like
LabelStyle,LineStyle,MarkerStyle, etc. to provide top-level shortcut properties to things likeLabelRotation,LineWidth, andMarkerSize.This strategy minimizes code duplication inside plottables and standardizes how these configurations are set (e.g.,
TextSizevs.FontSize)Resolves #3658
LabelStyleLineStyleFillStyleMarkerStyleArrowStyle