FormsPlot: dispose the Plot when the handle is destroyed#3593
Merged
swharden merged 5 commits intoScottPlot:mainfrom Apr 5, 2024
Merged
FormsPlot: dispose the Plot when the handle is destroyed#3593swharden merged 5 commits intoScottPlot:mainfrom
swharden merged 5 commits intoScottPlot:mainfrom
Conversation
…ndow opens second time. V4 works as expected. The issue was, when the dialog was closed, Plot was not being disposed when the HandleDestroyed fired. It just disposed the SKElement.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
swharden
changed the title
Contributor
Author
|
Sorry about the SonarQube thing. I didn't see that it was added. |
Member
No worries! I'm relieved to learn the fix to the issue didn't actually require 1.4 million lines of code 😜 This was a great fix, thanks again! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3589
The issue was, when the dialog was closed, Plot was not being disposed when the HandleDestroyed fired, which it did when the user X'd out of the dialog. It only disposed the SKElement.
This was tested on the user-supplied test project.