SquareZoomOut Axis Rule: add support for inverted axes#3592
Merged
swharden merged 9 commits intoScottPlot:mainfrom Apr 5, 2024
Merged
SquareZoomOut Axis Rule: add support for inverted axes#3592swharden merged 9 commits intoScottPlot:mainfrom
swharden merged 9 commits intoScottPlot:mainfrom
Conversation
…om: 1.5, top: -1.5);
Member
|
Hi @VisMotrix, thanks for this fix! I extended this PR to make some additional improvements to the axis system. I'm merging this in now so the square zoom rules work support inverted axes, but other axis rules still don't support them so I opened #3597 to track progress toward that fix in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…om: 1.5, top: -1.5);
This PR fixes the axis range setting if you use the SquareZoomOut and AutoScaler.InvertedX / Y
This code did not "keep" the SetLimit / AutoScaler.InvertedY setting cause SquareZoomOut rule just sets YAxis.Range.Set(yMin, yMax); we need to distinguish if the axis got inverted.