Label: Don't draw border when line width is 0#3572
Merged
swharden merged 3 commits intoScottPlot:mainfrom Apr 3, 2024
Merged
Conversation
Member
|
Another great fix @bwedding, I'm happy to merge this in and it will be in the next release! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #3538
In SkiaSharp, setting the StrokeWidth to 0 does not guarantee that no border will be drawn. A StrokeWidth of 0 is interpreted as the thinnest line that can be drawn on the device, which is not the same as not drawing a line at all.
So I just wrapped the code to draw the border with a conditional to only paint it if borderwidth is greater than 0. This works fine on the recipe code when setting BorderWidth = 0;
Issue 3538