Fix rendering problems in AvaloniaUI#3517
Merged
swharden merged 5 commits intoScottPlot:mainfrom Mar 22, 2024
chjrom:main
Merged
Fix rendering problems in AvaloniaUI#3517swharden merged 5 commits intoScottPlot:mainfrom chjrom:main
swharden merged 5 commits intoScottPlot:mainfrom
chjrom:main
Conversation
Member
|
Thanks for this fix @chjrom! I don't recall why that was added, but I'll go ahead and merge this in and keep an eye out for any unexpected behavior. It makes sense that any action that enables clipping should manage it within the action, disabling it before returning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dc0c4b3.
I think the issue occurs because the methods
Canvas.Restoreare called multiple times.Fix #3516, #3502.