Proposed implementation of an Annotation Plottable#3510
Merged
swharden merged 13 commits intoScottPlot:mainfrom Mar 19, 2024
Merged
Proposed implementation of an Annotation Plottable#3510swharden merged 13 commits intoScottPlot:mainfrom
swharden merged 13 commits intoScottPlot:mainfrom
Conversation
dlampa
changed the title
Member
|
Thanks so much @dlampa, this looks great! I'm going to merge this now but feel free to open a new PR if you have ideas for refinements. I moved some stuff around to simplify the code in this plottable (and future plottables as well). I'm excited to have this in the next release! 🚀 |
This was referenced Mar 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to issue #3356
Outstanding issues:
MarginX/MarginYimplementation