Change Plot.ScaleFactor from float to double#3455
Merged
swharden merged 4 commits intoScottPlot:mainfrom Mar 14, 2024
Merged
Conversation
swharden
changed the title
Plot.ScaleFactor from float to double
Member
|
haha, that change touched a lot more lines of code than I expected it would 😅 I'll see if I can simplify this somehow, and merge shortly. Thanks so much! 🚀 |
store a float-casted version of ScaleFactor to prevent inline casting in internal calls that use scale factor when working with pixel (single precision floating point) units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the title. Will fix #3454