Skip to content

Pie chart: add support for "donut" display style#3447

Merged
swharden merged 11 commits intoScottPlot:mainfrom
aespitia:feature/aespitia/sp5-donut-piechart
Mar 14, 2024
Merged

Pie chart: add support for "donut" display style#3447
swharden merged 11 commits intoScottPlot:mainfrom
aespitia:feature/aespitia/sp5-donut-piechart

Conversation

@aespitia
Copy link
Contributor

@aespitia aespitia commented Mar 6, 2024

#3438

this is to add the donut functionality that was in SP4 and port to SP5.

@aespitia
Copy link
Contributor Author

aespitia commented Mar 7, 2024

would love feedback on this @swharden, my first time messing with the actual rendering code, so I wouldn't be surprised if there's another/better way to do this.

@swharden swharden changed the title feat: sp5 donut piechart Pie chart: add support for "donut" display style Mar 13, 2024
@swharden
Copy link
Member

Thanks so much for this @aespitia!

I'm going to modify this PR slightly to draw the outline around the inner donut, then merge 🚀

image

@swharden
Copy link
Member

swharden commented Mar 14, 2024

draw the outline around the inner donut

Oof, this got complicated fast 😱 It means we need to use a path and "ArcTo" instead of the clever clipping method 🤦

I'm going to merge this now and create a new issue to track that refinement. If you want to have a go at it, awesome! If not, that's okay too - someone from the community may get to it. If not, I'll implement it eventually 😎 I'm attempting it now...

@swharden
Copy link
Member

swharden commented Mar 14, 2024

Got it! That was actually super confusing 🤪

image

image

@swharden swharden linked an issue Mar 14, 2024 that may be closed by this pull request
@swharden swharden enabled auto-merge March 14, 2024 23:46
@swharden swharden merged commit 531dc1e into ScottPlot:main Mar 14, 2024
@aespitia
Copy link
Contributor Author

awesome, thanks so much!

@aespitia aespitia deleted the feature/aespitia/sp5-donut-piechart branch March 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to create a doughnut chart in Scott Plot 5

2 participants