Pie chart: add support for "donut" display style#3447
Merged
swharden merged 11 commits intoScottPlot:mainfrom Mar 14, 2024
Merged
Pie chart: add support for "donut" display style#3447swharden merged 11 commits intoScottPlot:mainfrom
swharden merged 11 commits intoScottPlot:mainfrom
Conversation
Contributor
Author
|
would love feedback on this @swharden, my first time messing with the actual rendering code, so I wouldn't be surprised if there's another/better way to do this. |
Member
|
Thanks so much for this @aespitia! I'm going to modify this PR slightly to draw the outline around the inner donut, then merge 🚀 |
Member
Oof, this got complicated fast 😱 It means we need to use a path and "ArcTo" instead of the clever clipping method 🤦
|
Member
Contributor
Author
|
awesome, thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



#3438
this is to add the donut functionality that was in SP4 and port to SP5.