SP5: Fix typeface caching#3334
Merged
swharden merged 4 commits intoScottPlot:mainfrom Feb 19, 2024
Milkitic:fix/caching-typeface
Merged
SP5: Fix typeface caching#3334swharden merged 4 commits intoScottPlot:mainfrom Milkitic:fix/caching-typeface
swharden merged 4 commits intoScottPlot:mainfrom
Milkitic:fix/caching-typeface
Conversation
Member
|
Great catch @Milkitic, thanks so much for my fix! I was sick for a few weeks and got behind on issues and PRs, but I'm happy to be merging this in now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3335
Checked #2848 and #2419, but it seems that the issue is not actually fixed in the latest branch.
It causes critical performance issues in Linux systems.
In KUbuntu 23.10 with Avalonia 11.0.7 , the problem still exists as below:
After fixing:
Just simply modifed the code to reach the caching goals: