SP5 Plot: Fix GetPixel bug when ScaleFactor is not 1.0#3328
Merged
swharden merged 4 commits intoScottPlot:mainfrom Feb 19, 2024
Merged
SP5 Plot: Fix GetPixel bug when ScaleFactor is not 1.0#3328swharden merged 4 commits intoScottPlot:mainfrom
swharden merged 4 commits intoScottPlot:mainfrom
Conversation
The input Coordinates where being scaled which was incorrect. Output Pixels are now being scaled, which is correct.
Convert from Pixel to Coordinates and back again - with the default ScaleFactor of 1.0 and with a non-default of 2.5.
Member
|
This looks great! Thanks @MCF. I was sick for a few weeks and got a bit behind on issues and PRs, but I'm happy to merge this in now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3327
A per title, fixes the GetPixel bug. Includes 2 new unit tests for the fix.
I've taken the liberty of updating the CHANGELOG. Apologies if this makes the merge more complicated.