Skip to content

SP5: Line (new plot type)#3109

Merged
swharden merged 11 commits intoScottPlot:mainfrom
Gray-lab:issue-2915-line-plot
Dec 23, 2023
Merged

SP5: Line (new plot type)#3109
swharden merged 11 commits intoScottPlot:mainfrom
Gray-lab:issue-2915-line-plot

Conversation

@Gray-lab
Copy link
Contributor

Purpose:

  • Resolves SP5: Line plot type #2915
  • Add Line primitive
  • Add LinePlot plot type
  • Add Cookbook entry for Line plot
  • Add RandomLinePattern method to Generate

The results of the cookbook plots - I used the Marker cookbook plots as a template:
LineQuickStart
LinePlotStyles
LinePlotLegend

@Gray-lab
Copy link
Contributor Author

I am not sure what is causing the crash during the Test on Windows - it isn't happening locally. I will keep looking into it but I am not sure yet.

@Gray-lab Gray-lab marked this pull request as draft December 21, 2023 04:16
@swharden
Copy link
Member

Hi @Gray-lab, thanks for this PR it looks awesome!

Tests run fine on my computer too... Issues specific to the CI system are difficult to troubleshoot but I'll look into it now.

The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at SkiaSharp.SKAbstractManagedWStream.WriteInternal(IntPtr s, Void* context, Void* buffer, IntPtr size)
   at SkiaSharp.SkiaApi.sk_canvas_destroy(IntPtr param0)
   at SkiaSharp.SKCanvas.DisposeNative()
   at SkiaSharp.SKNativeObject.Dispose(Boolean disposing)
   at SkiaSharp.SKCanvas.Dispose(Boolean disposing)
   at SkiaSharp.SKNativeObject.Finalize()

@swharden swharden changed the title Issue 2915 line plot SP5: Line (new plot type) Dec 23, 2023
@swharden
Copy link
Member

Issues specific to the CI system are difficult to troubleshoot

after re-running the tests they pass now 🤷

I made a few small changes and am about to merge this in. Thanks again! 🚀

@swharden swharden marked this pull request as ready for review December 23, 2023 02:36
@swharden swharden enabled auto-merge December 23, 2023 02:37
@Gray-lab
Copy link
Contributor Author

Thank you so much! I was at a loss as to how to troubleshoot and suspected it might have been something transient. Also thank you for the positive feedback! :)

@swharden swharden merged commit d5dacc3 into ScottPlot:main Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SP5: Line plot type

2 participants