Merged
Conversation
Contributor
Author
|
I am not sure what is causing the crash during the Test on Windows - it isn't happening locally. I will keep looking into it but I am not sure yet. |
Member
|
Hi @Gray-lab, thanks for this PR it looks awesome! Tests run fine on my computer too... Issues specific to the CI system are difficult to troubleshoot but I'll look into it now. |
previously all markers were rendered as circles
Member
after re-running the tests they pass now 🤷 I made a few small changes and am about to merge this in. Thanks again! 🚀 |
Contributor
Author
|
Thank you so much! I was at a loss as to how to troubleshoot and suspected it might have been something transient. Also thank you for the positive feedback! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Lineplot type #2915The results of the cookbook plots - I used the Marker cookbook plots as a template:


