SP4: Fix ScatterPlotDraggable#3025
Merged
swharden merged 3 commits intoScottPlot:mainfrom Nov 29, 2023
Merged
Conversation
This should resolve issues with ScatteerPlotDraggable (ScottPlot#2870 and ScottPlot#2969): - remove duplicated members `Xs` and `Ys`, they are already managed by base class `ScatterPlot` - ensure a valid point is selected before trying to update its position - avoid possible exception with `PointCount` when no data is set
Member
|
Fantastic fix @KroMignon! I really appreciate all your help on these recent issues 😄🙏🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
This should resolve issues with
ScatteerPlotDraggable(#2870 and #2969):XsandYs, they are already managed by base classScatterPlotPointCountwhen no data is set