SP4: Improve Bitmap disposal as controls are unloaded#3023
Merged
swharden merged 4 commits intoScottPlot:mainfrom Nov 29, 2023
Merged
SP4: Improve Bitmap disposal as controls are unloaded#3023swharden merged 4 commits intoScottPlot:mainfrom
swharden merged 4 commits intoScottPlot:mainfrom
Conversation
ControlBackEnd implements now `IDisposable`. When disposing (or on destruction), all bitmaps in `OldBitmaps` queue and `Bmp` are disposed to avoid memory overflow.
Member
|
Great work @KroMignon, thanks so much! I opened #3029 to track progress toward a similar fix in ScottPlot 5. It doesn't have to be resolved right away because I'm still refactoring the rendering system, but this topic will be revisited again as ScottPlot 5 matures. Thanks again! 🚀 |
This was
linked to
issues
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControlBackEnd implements now
IDisposable.When disposing (or on destruction), all bitmaps in
OldBitmapsqueue andBmpare disposed to avoid memory overflow.This should fix issue #2902