Skip to content

SP5: Create OpenGL and Non-OpenGL controls#3008

Merged
swharden merged 7 commits intomainfrom
2941
Nov 25, 2023
Merged

SP5: Create OpenGL and Non-OpenGL controls#3008
swharden merged 7 commits intomainfrom
2941

Conversation

@swharden
Copy link
Member

OpenGL rendering can cause issues when displaying multiple controls (#3007) and problems for rendering on newer hardware platforms (#2950)

This PR creates separate FormsPlot, FormsPlotGL, WpfPlot, and WpfPlotGL controls

One advantage is that the WpfPlot can use the official SKElement and not the unofficial SKGLElement we've been carrying in ScottPlot's code base (#2395) because it doesn't seem to be in the official package yet mono/SkiaSharp#2317

I don't think this is an ideal long term solution. A better solution would be an easier way for users to opt-in to OpenGL acceleration using the same control. This was feasible for the WinForms control, but I had trouble getting this to work in the WPF control because of issues related to templating (#2565)

@swharden swharden disabled auto-merge November 25, 2023 19:55
@swharden swharden merged commit 3fd752a into main Nov 25, 2023
@swharden swharden deleted the 2941 branch November 25, 2023 19:58
@swharden
Copy link
Member Author

swharden commented Nov 25, 2023

Following-up, wow, the OpenGL control doesn't do much to improve performance on my system

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant