SP4: Support LineStyle in DataLogger and DataStreamer#3005
Merged
swharden merged 6 commits intoScottPlot:mainfrom Nov 24, 2023
Merged
SP4: Support LineStyle in DataLogger and DataStreamer#3005swharden merged 6 commits intoScottPlot:mainfrom
swharden merged 6 commits intoScottPlot:mainfrom
Conversation
swharden
changed the title
Member
|
Thanks @Gray-lab, this looks great! 🚀 |
Member
|
Oh yeah, bonus points for the test that demonstrate this fix too! 🚀 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
LineStyleNotes:
IsDifferentThanin the test assert to detect change inLineStyle, but it doesn't feel like the most precise way of testing this - open to suggestions here