SP5 FillY: Add legend support#2896
Conversation
msroest
left a comment
There was a problem hiding this comment.
Moved to Draft as FillY with no linestyle defined the legend doesn't show properly (it doesn't show the color just the label). Need to work on it more
I've changed the code to ignore the line style and set the legend to the fill color. I don't love it so I'm open to alternate ideas. also @swharden not sure if you have any ideas about the build failures on actions? I'm getting the same failure locally today which I wasn't getting yesterday. I haven't made any changes to csproj or solutions so I'm a bit stumped. If I do It compiles fine. |
|
Looks like the error is ScottPlot 5 also targets .NET Framework 4.6.2 so I'm guessing there's a language feature you're using that isn't supported by that framework I can take a closer look when I review this PR later today or tomorrow if it keeps failing unexpectedly build in the cloud. Thanks for this contribution, I look forward to merging it in and making it available in the next release! 🚀 |
Actually, don't worry about it! I just realized the errors are in the color code (unrelated to this PR), so let's keep this PR clean and focused just on FillY, and I'll swoop in and fix the color issues causing the build failure right before I merge 👍 Thanks again for this PR! |
Closes #2886
Seems to work as expected:
