Skip to content

SP5 FillY: Add legend support#2896

Merged
swharden merged 5 commits intoScottPlot:mainfrom
msroest:filly-legend
Sep 9, 2023
Merged

SP5 FillY: Add legend support#2896
swharden merged 5 commits intoScottPlot:mainfrom
msroest:filly-legend

Conversation

@msroest
Copy link
Contributor

@msroest msroest commented Aug 22, 2023

Closes #2886

Seems to work as expected:
image

@msroest msroest marked this pull request as draft August 23, 2023 00:17
Copy link
Contributor Author

@msroest msroest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Draft as FillY with no linestyle defined the legend doesn't show properly (it doesn't show the color just the label). Need to work on it more

@msroest msroest marked this pull request as ready for review August 23, 2023 00:35
@msroest
Copy link
Contributor Author

msroest commented Aug 23, 2023

Moved to Draft as FillY with no linestyle defined the legend doesn't show properly (it doesn't show the color just the label). Need to work on it more

I've changed the code to ignore the line style and set the legend to the fill color. I don't love it so I'm open to alternate ideas.

also @swharden not sure if you have any ideas about the build failures on actions? I'm getting the same failure locally today which I wasn't getting yesterday. I haven't made any changes to csproj or solutions so I'm a bit stumped. If I do

dotnet build -f net6.0 ScottPlot5-tests.slnf

It compiles fine.
Not really sure why it's now trying to compile net462 on linux/macos when it wasn't before (or wasn't failing before)

@swharden
Copy link
Member

Looks like the error is

Predefined type 'System.ValueTuple`3' is not defined or imported

ScottPlot 5 also targets .NET Framework 4.6.2 so I'm guessing there's a language feature you're using that isn't supported by that framework

<TargetFrameworks>net462;netstandard2.0;net6.0</TargetFrameworks>

I can take a closer look when I review this PR later today or tomorrow if it keeps failing unexpectedly build in the cloud.

Thanks for this contribution, I look forward to merging it in and making it available in the next release! 🚀

@swharden
Copy link
Member

Not really sure why it's now trying to compile net462 on linux/macos when it wasn't before (or wasn't failing before)

Actually, don't worry about it!

I just realized the errors are in the color code (unrelated to this PR), so let's keep this PR clean and focused just on FillY, and I'll swoop in and fix the color issues causing the build failure right before I merge 👍

Thanks again for this PR!

@swharden swharden merged commit 72298c0 into ScottPlot:main Sep 9, 2023
@msroest msroest deleted the filly-legend branch September 9, 2023 16:17
@swharden swharden changed the title Add legend support to FillY Plottable SP5 FillY: Add legend support Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SP5: Improve legend support for the FillY plot type

2 participants