SP5: CoordinateRectangle.Expanded()#2890
Merged
swharden merged 7 commits intoScottPlot:mainfrom Sep 9, 2023
Merged
Conversation
Contributor
Author
|
let me know if you have any feedback @swharden. |
Member
|
Thanks @aespitia, this looks great! I got backed-up on some other projects and this PR took a lot longer than typical to get to, but I really appreciate it! 🚀 |
swharden
changed the title
Contributor
Author
was a great first check-in experience. your feedback was super helpful and timely, looking forward to using SP5! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds an Expandable method to the rectangle that takes in a Coordinate. The method checks if the coordinate already exists in the rectangle, if it does, then it returns a copy of the existing rectangle, if it doesn't, the method will return an expanded version of the rectangle that does contain the new coordinate.
#2871