Skip to content

SP5: rename PixelPadding properties#2878

Merged
swharden merged 4 commits intoScottPlot:mainfrom
viktoriussuwandi:issue#2874
Sep 9, 2023
Merged

SP5: rename PixelPadding properties#2878
swharden merged 4 commits intoScottPlot:mainfrom
viktoriussuwandi:issue#2874

Conversation

@viktoriussuwandi
Copy link
Contributor

@viktoriussuwandi viktoriussuwandi commented Aug 14, 2023

fix #2874

Hi swharden,
just tying to help on this issue, please check it out

@swharden
Copy link
Member

just tying to help on this issue, please check it out

Awesome, thanks for working on this @viktoriussuwandi!

I won't merge this in tonight, but definitely tomorrow 🚀

@viktoriussuwandi
Copy link
Contributor Author

Hi @swharden,
Is there anything else need updated to merge this PR ? just lemme know :)

@swharden
Copy link
Member

swharden commented Sep 9, 2023

Thanks @viktoriussuwandi! Sorry this one took me so long to get to - I've been catching up on some other projects, but I'm back here now and merging this in 👍

@swharden
Copy link
Member

swharden commented Sep 9, 2023

image

😅😅😅

@swharden swharden enabled auto-merge September 9, 2023 15:35
@swharden swharden disabled auto-merge September 9, 2023 15:36
@swharden swharden merged commit 7391d3d into ScottPlot:main Sep 9, 2023
@swharden swharden changed the title Update src/ScottPlot5/ScottPlot5/Primitives/PixelPadding.cs SP5: rename PixelPadding properties Sep 9, 2023
@viktoriussuwandi viktoriussuwandi deleted the issue#2874 branch September 10, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PixelPadding: improve property names

2 participants