SP5 Avalonia: Implement ICustomDrawOperation to improve performance#2859
Merged
swharden merged 3 commits intoScottPlot:mainfrom Aug 10, 2023
Merged
SP5 Avalonia: Implement ICustomDrawOperation to improve performance#2859swharden merged 3 commits intoScottPlot:mainfrom
ICustomDrawOperation to improve performance#2859swharden merged 3 commits intoScottPlot:mainfrom
Conversation
…nnecessary axaml and changed AvaPlot type to Avalonia.Controls.Control.
Member
|
Hi @oktrue, this is a fantastic improvement! Thanks for this PR! @bclehmann if you're available to look this over I'd love your input too. Thanks! Related, Avalonia has a demo that shows how to create a control using |
swharden
changed the title
ICustomDrawOperation to improve performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies rendering logic in Avalonia by using CustomDrawOp instead of WriteableBitmap. So we directly render Plot into control's SkSurface.
This fixes #2818, also AvaPlot is DPI aware now.
This also has a performance impact.
In my case FPS increased from 400-600 to 900-1200 on Windows.