SP5 Scatter: Fix line renders even on Width of LineStyle to zero#2750
Merged
swharden merged 4 commits intoScottPlot:mainfrom Jul 13, 2023
Merged
SP5 Scatter: Fix line renders even on Width of LineStyle to zero#2750swharden merged 4 commits intoScottPlot:mainfrom
swharden merged 4 commits intoScottPlot:mainfrom
Conversation
Member
|
This looks great @dayo05, thanks so much! |
to see if the new CI system will automatically fix it after merging into the main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2739
Purpose:
Buggy features are introduced on that issue. This provides extra information by my research.
The code I provided works fine(just increase the width a lot instead setting that as zero)
It means rendering with width=0 is not supported on SkiaSharp. So, I just ignore path drawing call on LineStyle is invisible.
In the issue, LineStyle.NoLine just set the Width property to zero and because this affects, I think its required to create extra flow.