SP5 OpenGL Control: Fix keyboard input bug #2609#2616
Merged
swharden merged 4 commits intoScottPlot:mainfrom May 14, 2023
Merged
SP5 OpenGL Control: Fix keyboard input bug #2609#2616swharden merged 4 commits intoScottPlot:mainfrom
swharden merged 4 commits intoScottPlot:mainfrom
Conversation
Member
|
Thanks @StendProg! I was sick for a few weeks so it took me longer than typical to get to this, but I'm merging it in now 👍 |
swharden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Two plot control and keyboard input will stackoverflow #2609
This bug refers to
GLWPFControl. opentk/GLWpfControl#82They made it possible to bypass incorrect keypress handling in version 4.2.3.
This PR updates the version of
GLWPFControl, and disables incorrect event handling byGLWPFControlitself. ScottPlot.WPF's keyboard handlers continue to work correctly if the control gets focus.