Skip to content

ScottPlot.WPF based on GL accelerated control#2395

Merged
swharden merged 4 commits intoScottPlot:mainfrom
StendProg:WPFControlGLSupport
Feb 18, 2023
Merged

ScottPlot.WPF based on GL accelerated control#2395
swharden merged 4 commits intoScottPlot:mainfrom
StendProg:WPFControlGLSupport

Conversation

@StendProg
Copy link
Contributor

Purpose:
SkiaSharp haven't GPU accelerated control for WPF.
But there is PR in SkiaSharp with such control started at Nov 22. mono/SkiaSharp#2317
I tested a bit, and it looks finished.
So i grab the code and place it in ScottPlot.WPF.
If and when the PR is approved we can simply remove the code and change the link.

@swharden
Copy link
Member

I tested a bit, and it looks finished.

This is a great find! Thank you so much for this PR 😄

If and when the PR is approved we can simply remove the code and change the link.

I love this plan!

@swharden swharden added this pull request to the merge queue Feb 18, 2023
Merged via the queue into ScottPlot:main with commit ec31357 Feb 18, 2023
@StendProg
Copy link
Contributor Author

Hi @swharden,

PR with SKGLElement has finally been accepted into SkiaSharp. Now we can give up our own copy, but there is a catch.
This PR is in the Preview version of SkiaSharp 3.0 and we will probably have to wait until version 3 goes to release.
I've tested the SKGLElement replacement and at a quick glance it works as it should.
I didn't do a PR because you probably don't want to use the Preview version of SkiaSharp in ScottPlot.WPF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants