Fix bug where only one tick label appears sometimes#2280
Merged
swharden merged 4 commits intoScottPlot:mainfrom Dec 21, 2022
Merged
Fix bug where only one tick label appears sometimes#2280swharden merged 4 commits intoScottPlot:mainfrom
swharden merged 4 commits intoScottPlot:mainfrom
Conversation
Contributor
Author
|
I noticed that same Mac test fails in other people's pull requests as well. Not sure what the deal is with that, but not related to this PR. Looks to be some kind of color test. |
Member
|
Thanks for this @Xerxes004! Sorry it took me longer to get to this than typical (see #2304 for details)
Something crazy happened to the cloud mac build computers... I'll figure it out later 😅 This PR looks great, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Sometimes, only one tick label would appear on an axis. This was because sometimes the 'ideal' tick spacing wasn't ideal after all. When calculating the ideal tick spacing, I check to see if it's possible the spacing could be too high, then select the next-smaller spacing instead.
See #2278