#2199 - make FinancePlot sort OHLCs when getting SMA or Bollinger bands#2207
Merged
swharden merged 4 commits intoScottPlot:mainfrom Oct 31, 2022
Merged
#2199 - make FinancePlot sort OHLCs when getting SMA or Bollinger bands#2207swharden merged 4 commits intoScottPlot:mainfrom
swharden merged 4 commits intoScottPlot:mainfrom
Conversation
bclehmann
approved these changes
Oct 30, 2022
zachesposito
force-pushed
the
2199-ohlc-sorting
branch
from
8a1f0b3 to
fa753d1
Compare
swharden
approved these changes
Oct 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
#2199 highlighted that
FinancePlot's assumption that itsOHLCsare always sorted by datetime can be confusing to users. This change makes sureOHLCsgets sorted before trying to calculate SMAs or BollingerBands, so that those methods work even if the user doesn't provide sorted OHLCs.