Bar Plot: Show negative values below bar#2159
Merged
swharden merged 9 commits intoScottPlot:mainfrom Oct 8, 2022
Merged
Conversation
Member
Author
|
When adding this to
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
#2148
Note that this PR doesn't yet add this forBarSeries, I'm writing this between classes so I'll add it later.The other question is whether this should be customizable, is drawing the text above negative bars always wrong (i.e. this is a bug fix), or should the user be able to choose that behaviour (i.e. this is a new feature). If it's the latter, I think we should preserve the previous behaviour of
ShowValuesAboveBarsand addShowValuesAtTipOfBaror something similar.