FunctionPlot: Massive performance boosts for functions with restricted domains#2158
Merged
swharden merged 6 commits intoScottPlot:mainfrom Oct 7, 2022
Merged
FunctionPlot: Massive performance boosts for functions with restricted domains#2158swharden merged 6 commits intoScottPlot:mainfrom
swharden merged 6 commits intoScottPlot:mainfrom
Conversation
Member
Author
|
I would make a benchmark, but the difference is so stark that before this PR I didn't have the patience to wait for it to render (admittedly in debug mode), and after this PR it's borderline instant |
swharden
approved these changes
Oct 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
#2156
Most of the performance benefit comes from removing the exception-based code (that's my bad, it was my idea in the first place).
XMinandXMaxare just gravy, and they also are potentially useful in and of themselves, if someone only wants to consider a function on a narrow domain, this is probably an easier way to restrict that domain then manually modifying the function.