Skip to content

Consistent 12/24 hour clock in DateTime ticks#2135

Merged
swharden merged 7 commits intoScottPlot:mainfrom
bclehmann:fix/consistent-24-hour-clock
Sep 28, 2022
Merged

Consistent 12/24 hour clock in DateTime ticks#2135
swharden merged 7 commits intoScottPlot:mainfrom
bclehmann:fix/consistent-24-hour-clock

Conversation

@bclehmann
Copy link
Member

Purpose:
#2132

This solution detects if a locale uses a 24-hour clock and adjusts some hard-coded time formats to generate 24-hour times.

@bclehmann
Copy link
Member Author

Also discussed (but not acted upon) in #2132 was how the format of times involving milliseconds is not locale aware.

For example, under the locale fr-CA (Canadian French), we would generate the time 23:59:59.999, but we should generate 23h59m59.999 (I think, depends how well I remember from French class).

@swharden swharden enabled auto-merge September 28, 2022 21:55
@swharden swharden merged commit 822a3fb into ScottPlot:main Sep 28, 2022
@swharden swharden mentioned this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DateTimeTickUnits: The X-axis of DateTime mixture 24-hour and 12-hour notation.

2 participants