Signal and Scatter: GetYDataRange()#1946
Merged
swharden merged 4 commits intoScottPlot:mainfrom Jul 14, 2022
Merged
Conversation
favor xMin and xMax over xStart and xEnd for consistency
Member
|
Looks great, thanks @bclehmann! 🚀
Behavior like this can be pretty difficult to document effectively in the cookbook (especially as it affects multiple - but not all - plottables). I added XML docs to these functions which I think will make it a little easier to find, but I think tactically mentioning them by name in answers to questions is the most practical way to reference them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Adds
GetYDataRangetoIHasPointsGenericX. This interface is implemented by ScatterPlots and SignalPlots (and their derivatives). #1942, #1929I wrote some tests, though they might be a little sparse. I'm not sure how this should be put in the cookbook? I suppose we could just draw a line at the bounds like we did for nth-order statistics and quantiles: https://scottplot.net/cookbook/4.1/category/statistics/#quantiles