Extract IHasAxisLimits, IHasDataValidation, and IHasLegendItems from IPlottable#1881
Merged
Extract IHasAxisLimits, IHasDataValidation, and IHasLegendItems from IPlottable#1881
IHasAxisLimits, IHasDataValidation, and IHasLegendItems from IPlottable#1881Conversation
swharden
added a commit
that referenced
this pull request
Jun 9, 2022
This commit moves GetAxisLimits, GetLegendItems, and ValidateData back into IPlottable, reversing work done in #1881. Having separate interfaces such as IHasAxisLimits made sense (e.g., colorbar has no axis limits), but segregating this functionality means users who created their own plottables that previously just implemented IPlottable may not realize they need to implement these new interfaces, resulting in silent failure (unexpected change in behavior). Resolves #1868
Merged
swharden
changed the title
IHasAxisLimits, IHasDataValidation, and IHasLegendItems from IPlottable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this PR is to promote interface segregation (e.g., colorbar has no axis limits). resolves #1868
EDIT: this work was later reverted to maintain consistent behavior for users who implemented their own plottables implementing
IPlottableand may not be aware of these new interfaces.