BarPlotBase: Fixes axis calculation.#1857
Merged
swharden merged 5 commits intoScottPlot:mainfrom Jun 2, 2022
Merged
Conversation
There were two issues:
- ValueOffsets was not taken into account when calculating ValueMin
- ValueOffsets was not taken into account when ensuring the base of
the bar was within [ValueMin, ValueMax]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
#1855
There were two issues:
ValueOffsetswas not taken into account when calculatingValueMinValueOffsetswas not taken into account when ensuring the base of the bar was betweenValueMinandValueMaxThe second one is a little hard to explain without referencing the code, but there used to be these two lines:
This calculation is incorrect because the base of the bar is really
ValueBase + ValueOffsets[i], so for non-zeroValueOffsets[i]you get incorrect results, such as with the following code:Before:

Note that the axis goes from -100 to 0, as it's trying to keep
ValueBase = 0in frame, but it should be keepingValueBase + ValueOffsets[i] = -100in frameAfter:
