SignalPlotXY: defer ascending X check to ValidateData and only validate between min/max render index#1777
SignalPlotXY: defer ascending X check to ValidateData and only validate between min/max render index#1777swharden merged 7 commits intoScottPlot:mainfrom BAUR-GmbH:1771-signalxy-only-check-x-values-between-min-and-max-render-index
Conversation
…te between min/max render index
|
Hi @bernhardbreuss, sorry it took so long for me to get to this! This is a hard problem, but I think your solution is a good one. Unfortunately I can't edit contents of this pull request. Can you edit it to give me permissions to make changes, then I'll make some small updates and merge it in? Thanks! 🚀 |
|
Hi @swharden, I am afraid but the information in the provided link seems only to work for forks owned by a personal account. However I have added you as a collaborator. Hopefully this way you can also edit the PR branch. |
That worked, thanks! I'll make a few changes then merge this in shortly. I recommend not committing new changes on your end while I'm actively working on it 👍 Thanks again for starting this PR! This will be a great improvement to the library 🚀 |
…n-and-max-render-index
|
I reached a good compromise in my last few commits.
|
|
Hi @swharden, thank you for your hard work. ScottPlot is a great lib, easy and straight forward to use. |
Hi @swharden,
I have tried to solve #1771 by validating X only between min/max render index.
Doing the check only between min/max render index in the setter didn't worked out very well:
AddSignalXYwhich then already started to look like the obsoletePlotSignalXYTherefore I decided to only use the already present check in
ValidateData.