Merged
Conversation
…can draw a rectangle in addition to legacy behavior)
…operties into account - `lineWidth` and `isRectangle` properties are dropped
Merged
to prevent breaking changes from PR ScottPlot#1692
to prevent breaking changes from PR ScottPlot#1692 EDIT: I now see this field name was originally a typo
This comment was marked as resolved.
This comment was marked as resolved.
partially reverts changes introduced in ScottPlot#1692
Contributor
Author
Yeah, it was not yet ready for a merge I believe but that's fine ^^. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a
IHasAreainterface to handle plots that have some sort ofAreaplotted.The goal is to implement a common interface for
AxisSpan,Pie/Donut...Basically the interface comes in addition to
IHasColorthan only handles a line color or area fill color withBorderColorBorderLineWidthBorderLineStyleHatchColorHatchStyleAmong the benefits, the current way of creating
LegendItemfor such plots is to define theirLineWidthas 10 resulting in the setting of theisRectangleproperty totrue, this new interface allows to draw a specific type of legend item for this kind of plottables.This allows to update some plots by adding new properties, such as in
AxisSpanthat serves as a demonstration case for this new interface.At the moment the other plots that do not implement
IHasAreahave their legend items brokenHere is a preview of the
AxisSpancreated using the modified example in 1622529