MarkerPlot: respect plot borders and correctly display legend#1459
Merged
swharden merged 2 commits intoScottPlot:masterfrom Dec 20, 2021
Merged
MarkerPlot: respect plot borders and correctly display legend#1459swharden merged 2 commits intoScottPlot:masterfrom
swharden merged 2 commits intoScottPlot:masterfrom
Conversation
Ammarsultan997
approved these changes
Nov 29, 2021
Ammarsultan997
approved these changes
Nov 29, 2021
This was
linked to
issues
Dec 20, 2021
Member
|
Thanks for this PR @PremekTill! This is a simple fix bug a strong improvement 👍 Also thanks to @lucabat, @AndXaf, and @Logicman111 for noting the issues and offering suggestions. Sorry for the delay! It took me an unexpectedly long time to get to this because I moved houses and it was a lot more disruptive than I predicted, then right after I got sick for several weeks. I'm doing better now and am happy to be picking this up again. Thanks for your patience along the way! |
|
Hey Scott,great that you are back :-)And good to hear that privately everything turned out well finally!Greetings from Germany!Von meinem/meiner Galaxy gesendet
-------- Ursprüngliche Nachricht --------Von: Scott W Harden ***@***.***> Datum: 21.12.21 00:02 (GMT+01:00) An: ScottPlot/ScottPlot ***@***.***> Cc: AndXaf ***@***.***>, Mention ***@***.***> Betreff: Re: [ScottPlot/ScottPlot] MarkerPlot: respect plot borders and
correctly display legend (PR #1459)
Thanks for this PR @PremekTill! This is a simple fix bug a strong improvement 👍
Also thanks to @lucabat, @AndXaf, and @Logicman111 for noting the issues and offering suggestions.
Sorry for the delay! It took me an unexpectedly long time to get to this because I moved houses and it was a lot more disruptive than I predicted, then right after I got sick for several weeks. I'm doing better now and am happy to be picking this up again. Thanks for your patience along the way!
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for issues #1423 and #1454.