Skip to content

Define polygon outline border thickness#1426

Merged
swharden merged 8 commits intoScottPlot:masterfrom
Rayffer:master
Nov 16, 2021
Merged

Define polygon outline border thickness#1426
swharden merged 8 commits intoScottPlot:masterfrom
Rayffer:master

Conversation

@Rayffer
Copy link
Contributor

@Rayffer Rayffer commented Nov 10, 2021

Purpose:
This pull request aims to provide the possibility to specify a Radar Chart's polygon outline
#1277

To specify outline, type the following code

    double[,] values = {
        { 5, 3, 10, 15, 3, 2 },
        { 5, 2, 10, 10, 1, 4 },
    };

    var radar = plt.AddRadar(values);
    radar.OutlineThickness = 3;

@bclehmann
Copy link
Member

bclehmann commented Nov 12, 2021

Hey, it looks like this PR is based off of a pretty out of date head (from mid-september). I think you need to rebase.

@Rayffer
Copy link
Contributor Author

Rayffer commented Nov 15, 2021

Done, thought I was up to date in my fork, thanks for the heads up!

bclehmann
bclehmann approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@bclehmann bclehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't know why the CI failed, but I don't think it had anything to do with you

@swharden swharden linked an issue Nov 16, 2021 that may be closed by this pull request
Allow Radar Chart to specify a width for the Radar's border #1277
Closed
@swharden
Copy link
Member

swharden commented Nov 16, 2021

Hi @Rayffer, thanks for this PR! Sorry for the long delay on this one - I'm in the middle of moving and the process has been a lot more disruptive than I anticipated it would be.

Looks good, I don't know why the CI failed, but I don't think it had anything to do with you

Indeed! Re-running the job it appears all the tests passed this time

Thanks for your help along the way @bclehmann!

@swharden swharden enabled auto-merge November 16, 2021 04:26
@swharden swharden merged commit e43b834 into ScottPlot:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swharden swharden swharden left review comments

+1 more reviewer

@bclehmann bclehmann bclehmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow Radar Chart to specify a width for the Radar's border

3 participants

@Rayffer @bclehmann @swharden