Skip to content

#1309 noted in changelog#1321

Merged
swharden merged 1 commit intoScottPlot:masterfrom
bclehmann:patch-2
Oct 3, 2021
Merged

#1309 noted in changelog#1321
swharden merged 1 commit intoScottPlot:masterfrom
bclehmann:patch-2

Conversation

@bclehmann
Copy link
Member

New Contributors:
Please review CONTRIBUTING.md

Hacktoberfest Participants:
Check-out the Hacktoberfest 2021 page

Purpose:
#1309 (comment)

@bclehmann
Copy link
Member Author

As an aside, it feels very weird to add "thanks @bclehmann" when you are @bclehmann.

@bclehmann
Copy link
Member Author

It also looks like you missed #1320, I don't know if you want to add that to this PR or a separate one?

@swharden
Copy link
Member

swharden commented Oct 3, 2021

it feels very weird to add "thanks @bclehmann" when you are @bclehmann

lol, true. That format originated because people often make suggestions in issues and they get mentioned/credited when the issue is fixed. I'm open to suggestions if you think there is better language we could use. I could change those as part of #1308 and they'd display on https://scottplot.net/changelog

It also looks like you missed #1320, I don't know if you want to add that to this PR or a separate one?

I think I'll specifically thank those that go above and beyond and/or make changes based on feedback before merging

@swharden swharden merged commit cdfdafe into ScottPlot:master Oct 3, 2021
@swharden swharden requested review from swharden and removed request for swharden October 3, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants