Skip to content

Controls: Remove render timer#1245

Merged
swharden merged 8 commits intomasterfrom
remove-render-timer
Sep 5, 2021
Merged

Controls: Remove render timer#1245
swharden merged 8 commits intomasterfrom
remove-render-timer

Conversation

@swharden
Copy link
Member

@swharden swharden commented Sep 5, 2021

This PR removes the control timer that previously called Render() automatically after the number of plottables changed.

This reduces complex/ambiguous behavior, but requires the user to manually call Render() at least once after instantiating a user control. #1165 #1117

Failing to call Render() manually causes a highly visible error message to appear on the plot:

renderfail

@swharden swharden marked this pull request as ready for review September 5, 2021 21:28
@swharden swharden linked an issue Sep 5, 2021 that may be closed by this pull request
@swharden swharden merged commit 3e21ce0 into master Sep 5, 2021
@swharden swharden deleted the remove-render-timer branch September 5, 2021 21:33
swharden added a commit that referenced this pull request Sep 8, 2021
Fixes a bug introduced in #1245 where the Plot and Backend become detached after Reset(). This bug caused cookbook recipes to stop working in the demo application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Controls: Remove timer-based auto-render system

1 participant