Skip to content

Coxcomb Chart#1188

Merged
swharden merged 8 commits intoScottPlot:masterfrom
bclehmann:polar-area-chart
Aug 21, 2021
Merged

Coxcomb Chart#1188
swharden merged 8 commits intoScottPlot:masterfrom
bclehmann:polar-area-chart

Conversation

@bclehmann
Copy link
Member

@bclehmann bclehmann commented Aug 6, 2021

New Contributors:
please review CONTRIBUTING.md

Purpose:
#1131

I have flip-flopped on the name a little bit, but for now I'm using Coxcomb.

New Functionality:
Describe what this pull request does using code and/or images.

var coxcomb = plt.AddCoxcomb(values);

image

@bclehmann bclehmann marked this pull request as draft August 6, 2021 01:54
@bclehmann bclehmann marked this pull request as ready for review August 7, 2021 01:26
@bclehmann
Copy link
Member Author

Worth noting that as part of this I refactored the same axis that RadarPlot uses. This could offer more customization options for radar plots, for example by letting users customize the tick placement.

@swharden
Copy link
Member

Hi @bclehmann thanks for this PR!

Worth noting that as part of this I refactored the same axis that RadarPlot uses. This could offer more customization options for radar plots, for example by letting users customize the tick placement.

I like what you did with StarAxis and StarAxisTick 👍

I'm also not worried that ValidateData() isn't implemented. I suspect the validation system will get reworked in the future (#1028)

@swharden swharden merged commit 2a9acbd into ScottPlot:master Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants