-
Notifications
You must be signed in to change notification settings - Fork 981
Description
Presently it's only included on Linux systems:
ScottPlot/src/ScottPlot5/ScottPlot5/ScottPlot.csproj
Lines 48 to 52 in ad66085
| <!-- Linux requires a special SkiaSharp package --> | |
| <ItemGroup Condition="'$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::Linux)))' == 'true'"> | |
| <PackageReference Include="SkiaSharp.NativeAssets.Linux" Version="2.*" /> | |
| <PackageReference Include="SkiaSharp.NativeAssets.Linux.NoDependencies" Version="2.*" /> | |
| </ItemGroup> |
... but I think this may be a mistake. Many "missing DLL" errors occur during Linux builds, and those target projects must add this package to fix the issue. However, adding it in the core ScottPlot package may fix it for everyone.
I think all it does is dump some extra files in the "runtimes" folder, and I'm not too worried about size because that folder already has contents for targets like osx, win-x64, win-x86, and win-arm64 for Windows builds. What's one more folder if it eliminates a whole class of issues?
Users who want to include ScottPlot in products who are also worried about size will already be deleting unnecessary runtime folders as part of their packaging process.