Skip to content

Commit ed2392e

Browse files
authored
Fix more unresolved doc comment references (flutter#193216)
Follow-up to flutter#192734 and flutter#193087. These are leftovers: four in `packages/flutter/test`, which the earlier PRs didn't cover, and a few one-offs. One fix removes a directive rather than changing a comment: `image_stream.dart` doc imported `dart:ui`, which made `[Image]` point at `dart:ui`'s `Image` rather than the widgets library's `Image`. Nothing needed that doc import: the file's `dart:ui` references are all prefixed, e.g.`[ui.Image]` and resolve through its real import. Towards flutter#192870 — enabling the `comment_references` lint.
1 parent 27b0154 commit ed2392e

9 files changed

Lines changed: 15 additions & 10 deletions

‎packages/flutter/lib/src/painting/debug.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
/// @docImport 'dart:developer';
66
/// @docImport 'dart:ui';
77
///
8+
/// @docImport 'package:flutter/widgets.dart';
89
/// @docImport 'package:flutter_test/flutter_test.dart';
910
///
1011
/// @docImport 'border_radius.dart';

‎packages/flutter/lib/src/painting/image_stream.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
/// @docImport 'dart:ui';
6-
///
75
/// @docImport 'package:flutter/widgets.dart';
86
///
97
/// @docImport 'image_cache.dart';

‎packages/flutter/lib/src/widgets/_platform_selectable_region_context_menu_web.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ class PlatformSelectableRegionContextMenu extends StatelessWidget {
7575
static RegisterViewFactory get _registerViewFactory =>
7676
debugOverrideRegisterViewFactory ?? ui_web.platformViewRegistry.registerViewFactory;
7777

78-
/// Override this to provide a custom implementation of [ui_web.platformViewRegistry.registerViewFactory].
78+
/// Override this to provide a custom implementation of
79+
/// [ui_web.PlatformViewRegistry.registerViewFactory].
7980
///
8081
/// This should only be used for testing.
8182
// See `_platform_selectable_region_context_menu_io.dart`.

‎packages/flutter/lib/src/widgets/scroll_delegate.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
/// @docImport 'editable_text.dart';
56
/// @docImport 'scroll_view.dart';
67
/// @docImport 'sliver.dart';
78
/// @docImport 'spacer.dart';

‎packages/flutter/lib/src/widgets/widget_inspector.dart‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1625,9 +1625,9 @@ mixin WidgetInspectorService {
16251625
/// This method triggers two actions:
16261626
/// 1. It calls [developer.inspect] on the provided [object], making it
16271627
/// available for inspection in Flutter DevTools.
1628-
/// 2. It posts a 'navigate' [ToolEvent] with the source code location of the
1629-
/// selected widget, allowing IDEs to navigate to the corresponding file
1630-
/// and line.
1628+
/// 2. It posts a 'navigate' event on the `ToolEvent` stream with the source
1629+
/// code location of the selected widget, allowing IDEs to navigate to
1630+
/// the corresponding file and line.
16311631
///
16321632
/// If [restrictToProjectFiles] is true and the selected widget is not from
16331633
/// the local project (i.e., it's from the Flutter framework or a package),

‎packages/flutter/test/system_context_menu_utils.dart‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
/// @docImport 'package:flutter/widgets.dart';
6+
library;
7+
58
import 'package:flutter/services.dart';
69
import 'package:flutter/widgets.dart' show FlutterError;
710

‎packages/flutter/test/widgets/image_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3366,6 +3366,6 @@ enum _DisableMethod {
33663366
/// Use [TickerMode.enabled].
33673367
tickerMode,
33683368

3369-
/// Use [MedaiQueryData.disableAnimations].
3369+
/// Use [MediaQueryData.disableAnimations].
33703370
mediaQuery,
33713371
}

‎packages/flutter/test/widgets/radio_group_tester.dart‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44

55
import 'package:flutter/widgets.dart';
66

7-
/// A stateful wrapper that hosts a [RadioGroup] with a mutable [groupValue],
8-
/// making it easy to pump and interact with radio buttons in tests.
7+
/// A stateful wrapper that hosts a [RadioGroup] with a mutable
8+
/// [RadioGroup.groupValue], making it easy to pump and interact with radio
9+
/// buttons in tests.
910
///
1011
/// See https://github.com/flutter/flutter/issues/177028.
1112
class TestRadioGroup<T> extends StatefulWidget {

‎packages/flutter/test/widgets/router_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2011,7 +2011,7 @@ class IntInheritedNotifier extends InheritedNotifier<ValueListenable<int>> {
20112011
}
20122012
}
20132013

2014-
/// A button widget that calls [setState] on tap, causing a rebuild.
2014+
/// A button widget that calls [State.setState] on tap, causing a rebuild.
20152015
///
20162016
/// Unlike [TestButton] (which uses a stateless [GestureDetector]), this widget
20172017
/// has internal state that changes on tap. This is needed for tests where the

0 commit comments

Comments
 (0)