Skip to content

[email protected]: Fix download & autoupdate URLs - #619

Merged
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
snowyukitty:fix/innosetup-download-url
Aug 7, 2026
Merged

[email protected]: Fix download & autoupdate URLs#619
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
snowyukitty:fix/innosetup-download-url

Conversation

@snowyukitty

@snowyukitty snowyukitty commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the HTML download-page redirect with the official versioned GitHub release asset and verified SHA-256
  • update the autoupdate template and remaining vendor pages to HTTPS
  • remove the unsupported legacy installer.#args property so the manifest passes the current schema

Validation

  • checkver: 6.7.3
  • checkhashes: OK
  • forced autoupdate regenerated the same URL and SHA-256
  • bucket tests: 138/138 on Windows PowerShell 5.1 and PowerShell 7.6.4
  • isolated current-user install, compiler, and uninstall smoke test: passed

Closes #618

@snowyukitty

snowyukitty commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

innosetup-np

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Summary by CodeRabbit

  • Chores
    • Updated Inno Setup download and metadata links to use secure HTTPS and current GitHub release sources.
    • Refreshed the package description and license information.
    • Replaced the installer checksum for version 6.7.3.
    • Improved update checks and automatic download URLs for future releases.
    • Added automatic checksum retrieval from release signature metadata.

Walkthrough

Changes

Inno Setup source update

Layer / File(s) Summary
Update package source metadata
bucket/innosetup-np.json		 The package description, homepage, license object, installer source, and 6.7.3 hash were updated.
Update version resolution
bucket/innosetup-np.json		 Version checks now use HTTPS. Autoupdates target GitHub release assets and retrieve hashes from the release .issig file.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR resolves issue #618 by replacing the HTML redirect with the versioned release asset and verified SHA-256 hash.
Out of Scope Changes check ✅ Passed The HTTPS updates, metadata changes, and removal of the unsupported property align with the stated PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly identifies the affected package version and the primary URL fixes.
Description check ✅ Passed The description includes a clear summary, validation results, issue reference, and completed contributing-guide confirmation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@z-Fng

z-Fng commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

innosetup-np

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng
z-Fng merged commit 9a6abd3 into ScoopInstaller:master Aug 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z-Fng z-Fng z-Fng approved these changes

Assignees

No one assigned

Labels

review-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[email protected]: hash check failed

2 participants

@snowyukitty @z-Fng