Skip to content

gh: Add version 0.6.1 - #841

Merged
niheaven merged 7 commits into
masterfrom
h404bi-patch-gh
Apr 1, 2020
Merged

niheaven merged 7 commits into
masterfrom
h404bi-patch-gh

Conversation

@chawyehsu

Copy link
Copy Markdown
Member

No description provided.

Comment thread bucket/gh.json Resolved
Comment thread bucket/gh.json Resolved
Comment thread bucket/gh.json Resolved
Comment thread bucket/gh.json Resolved
Comment thread bucket/gh.json Resolved
Chawye Hsu and others added 5 commits February 26, 2020 14:58
Co-Authored-By: Jakub Čábera <[email protected]>
Co-Authored-By: Jakub Čábera <[email protected]>
Co-Authored-By: Jakub Čábera <[email protected]>
Co-Authored-By: Jakub Čábera <[email protected]>
Co-Authored-By: Jakub Čábera <[email protected]>
@chawyehsu
chawyehsu requested a review from Ash258 February 26, 2020 07:04
@equinox

equinox commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Why are we just duplicating their own bucket? This seems a bit redundant to me.

@Ash258

Ash258 commented Feb 26, 2020 •

Copy link
Copy Markdown
Contributor

Why would someone need to add third party bucket without automatic updates and only with one poor quality manifest??

@chawyehsu

chawyehsu commented Feb 26, 2020 •

Copy link
Copy Markdown
Member Author

Why are we just duplicating their own bucket? This seems a bit redundant to me.

Ah interesting, I didn't notice that bucket.

Pros: manifests in this main bucket can be automatically updated by the Excavator, and users don't need to add another bucket by themselves.
Cons: it's not maintained by developers of gh.

I would like to file an issue in that bucket repo to tell it's maintainer that the gh manifest can be added into Scoop's main bucket.

@equinox

equinox commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

I would like to file an issue in that bucket repo to tell it's maintainer that the gh manifest can be added into Scoop's main bucket.

Sounds like a great idea! Another pro would be scoop-related issues would end up here, rather than there where they're probably not in a position to help users as effectively as people here.

I wonder if they chose to roll their own bucket because gh's was/still is in beta (cli/cli#280 (comment)) rather than wanting to keep an official bucket. In which case once they find out it could be added to the main bucket I'm guessing they'll go for it

@chawyehsu

Copy link
Copy Markdown
Member Author

Let's wait for gh developers' feedback.

@Ash258 Ash258 changed the title gh: Add version 0.5.7 gh: Add version 0.6.1 Mar 11, 2020
@JanPokorny

Copy link
Copy Markdown
Contributor

It might be possible to use an install script to automatically add gh completion -s powershell to PowerShell profile, similarly to Pshazz

@JanPokorny

Copy link
Copy Markdown
Contributor

@Ash258 It looks like the tool they use, goreleaser, has "scoop support" which works like this: https://goreleaser.com/scoop/

@mislav mislav left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm with of the GitHub CLI team. It's true that we initially set up our own scoop bucket because we were in beta. We still technically are in beta, but GitHub CLI is running pretty smoothly since then and receiving updates regularly, so feel free to add it to the main repository.

I can't comment on how to set up PowerShell completions because I have never done it and I don't know what, if at all, would be involved with setting them up from a scoop install.

Comment thread bucket/gh.json Resolved
@niheaven
niheaven merged commit cc9f852 into master Apr 1, 2020
@niheaven
niheaven deleted the h404bi-patch-gh branch April 1, 2020 13:20
@rasa rasa removed please-review waiting feedback Waiting for user feedback labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants