Add imagehash v4 links #14
Conversation
|
FWIW, you don't need to worry about the git repository size when you have two identical files in a repository: https://stackoverflow.com/a/29949004/741316 It definitely helps for user checkouts though... |
pelson
left a comment
pelson
left a comment
There was a problem hiding this comment.
Fine with me.
I don't fully have the bigger picture just yet, but from an incremental change perspective, no objections 👍
| exceptions = [] | ||
| for fname in glob.glob("images/*.png"): | ||
| for fname in glob.glob("images/v4/*.png"): | ||
| phash = imagehash.phash(Image.open(fname), hash_size=_HASH_SIZE) |
There was a problem hiding this comment.
Do we have the ability to pass the phash version to the function, or does imagehash not maintain backwards compatible image hashing functionality?
There was a problem hiding this comment.
It's a breaking change moving to v4. There's no way to generate the old hash from v4, hence the test coverage is only on the new images using the new imagehash v4.
To test the old hashes we'd need to install the pre-v4 imagehash ... and I'm kinda loathed to do that. Is that a safe approach to take?
2 participants
This PR converts all of the relevant
images/*.pngfrom old hash filenames to newimagehash 4.0hash filenames within theimages/v4directory.In order not to unnecessarily bloat the repo, the new hash filenames link to their associated old hash filename.
Note that, the new hash filename
fa81857e857e7a81857e7a817a81857a7a81857e857e7a85857e7a817a81857a.pnghas been added to correct a new failing test.